LangGraph migration #109
Merged
LangGraph migration #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Preview link: https://langchain-5e9cc07a-preview-brodyd-1754925111-e44a21e.mintlify.app/oss/python/overview This PR does two main things: 1. It reworks the `builder.py` file to generate JS and Python versions of the docs. 2. It adds CSS and JS files for conditionally hiding the language picker. The requirements for the picker are: - Show the picker when viewing the LangGraph docs - Hide the picker when viewing the LangGraph Platform or LangChain Labs docs ## Review requests + info We're doing custom things on top of Mintlify's stuff. It would be great if someone can help verify the changes to the `builder.py` file are acceptable, and although it's not the most elegant solution, that the CSS and JS files are an acceptable though likely temporary solution. I tried to update and fix tests appropriately but I really need someone to validate those changes are good. I haven't fixed/updated unit tests like this before. ## Todos - [x] Get this PR reviewed and implement any feedback - [x] Fix tests - [ ] Merge with #109 - [ ] 🎉 --------- Co-authored-by: Lauren Hirata Singh <[email protected]>
lnhsingh
commented
Aug 13, 2025
| if url.startswith("/oss/"): | ||
| parts = url.split("/") | ||
| # Insert full language name after "oss" | ||
| parts.insert(2, self.language_url_names[target_language]) |
There was a problem hiding this comment.
is this deducing the target language from the fenching? what if a link is outside of a fence?
There was a problem hiding this comment.
Links work inside and outside of the fencing. I think we kind of pre-set the languages and just swap them out depending on which version of the docs we're building at the time.
lnhsingh
commented
Aug 13, 2025
pipeline/core/builder.py
Outdated
| url = match.group(2) # The URL | ||
| post = match.group(3) # Everything after the URL | ||
|
|
||
| # Only rewrite absolute /oss/ paths |
There was a problem hiding this comment.
Noticed that this is also rewriting image paths, which it should ignore
There was a problem hiding this comment.
Thank you for flagging this, pushing a fix now!
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.